Skip to content

Add React 17 to Peer dependencies #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add React 17 to Peer dependencies #29

wants to merge 1 commit into from

Conversation

@RobinPayne
Copy link

@RobinPayne RobinPayne commented Dec 13, 2023

Package.json only lists ^16.8.0 as being compatible. with this library. I updated the peer dependencies so I don't get any problems with npm install.

When I try and install this library in my project I get an error similar to:

npm WARN Could not resolve dependency:
npm WARN peer react@"^16.8.0" from [email protected]
npm WARN node_modules/react-window-scroller
npm WARN   react-window-scroller@"1.0.10" from the root project
npm WARN 
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/react
npm WARN   peer react@"^16.8.0" from [email protected]
npm WARN   node_modules/react-window-scroller
npm WARN     react-window-scroller@"1.0.10" from the root project

This change fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@RobinPayne